Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mailer config #35

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Feature/mailer config #35

merged 4 commits into from
Feb 6, 2020

Conversation

schmunk42
Copy link
Member

CC: @eluhr

handcode
handcode requested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@handcode handcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • i would not use APP_TITLE as "name" in from (at least not without validation)
  • do not use domainnames in defaults

@schmunk42
Copy link
Member Author

Which "validation" should there be for a name?

@schmunk42 schmunk42 merged commit 8682e96 into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handcode handcode handcode requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmunk42 @handcode