Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9 Support Checklist #128

Closed
29 tasks done
dmulloy2 opened this issue Nov 13, 2015 · 30 comments
Closed
29 tasks done

1.9 Support Checklist #128

dmulloy2 opened this issue Nov 13, 2015 · 30 comments
Assignees
Milestone

Comments

@dmulloy2
Copy link
Owner

dmulloy2 commented Nov 13, 2015

ProtocolLib v4.0.0 has been released!

There are development builds available on my Jenkins server: http://ci.dmulloy2.net/job/ProtocolLib/

Here's the current progress:

Pre-release:

  • Use packet classes instead of ids - they're apparently subject to change in the future, this can be done before it is released
  • Figure out why updates 403
  • Release 3.6.5
  • Drop support for Java 6

Post-release:

  • Get it to compile with 1.9
  • Add support for new packets
  • Update class names
  • Make sure the server & plugin start
  • Make sure players can join & that injection works
  • Update server list handling for 1.9
  • Fix entity tracking issues
  • Update the particle enum
  • Update data watchers and watchable objects
  • Create wrappers for data watcher objects and serializers
  • Confirm that data watcher wrappers actually work
  • Make sure all necessary data watcher methods have been added back
  • Fix cloning
  • Misc bug fixes
  • Release 3.7.0-BETA

Full support:

  • Update packet types and IDs for 1.9
  • Get the JavaDocs working again
  • Add support for 1.9 enums
  • Add support for 1.9 wrappers
  • Restore disabled tests
  • Update documentation
  • Final bug fixes and testing
  • Release 4.0.0
  • Update TinyProtocol
  • Update PacketWrapper
@dmulloy2 dmulloy2 self-assigned this Nov 13, 2015
@dmulloy2 dmulloy2 added this to the 3.7 milestone Nov 13, 2015
dmulloy2 added a commit that referenced this issue Nov 14, 2015
Packet IDs will supposedly be shuffled in 1.9, so they are no longer
reliable for our packet associations. This shouldn't affect plugins,
unless you're using IDs, in which case you should stop doing that.

Addresses #128
@dmulloy2 dmulloy2 changed the title Spigot 1.9 1.9 Support Checklist Nov 14, 2015
@HeroCC
Copy link

HeroCC commented Feb 29, 2016

Thanks for all of your work on this plugin! It is a necessity for server owners and plugin developers alike. Good Luck with 1.9!

@tjbruce17594
Copy link

Thanks very much for this! :D

@Malachiel87
Copy link

Thank you for the good work, hope that it will get out :)

@vintagedon
Copy link

Thank you for your awesome, continued work on this. No spam to update, just a huge thanks for working on this!

@Sikatsu
Copy link

Sikatsu commented Mar 1, 2016

Thanks a lot! Appreciate your good work.

@mibby
Copy link

mibby commented Mar 1, 2016

Very much appreciated, thanks for continued support. :) Looking forward to when watchable objects are done.

@TNTUP
Copy link

TNTUP commented Mar 4, 2016

Great support to continue for 1.9! You're the king! ❤️

@vintagedon
Copy link

I come here a couple of times a day ... waiting for that check mark next to "Release 3.7.0-BETA" :)

@dmulloy2
Copy link
Owner Author

dmulloy2 commented Mar 7, 2016

@vintagedon I plan to release tomorrow barring any setbacks.

@vintagedon
Copy link

@dmulloy2 Awesome ... thanks so much for all your hard work; and for free, too.

@Litona
Copy link

Litona commented Mar 7, 2016

Hii, I'm using an util for SignGUIs. Since the 1.9 update and the new versions, I'm sadly getting an error. As I'm just using the util, I can't really get any information out of this error. It would be really great if you could just have a look at the error and then tell me if it's caused by protocollib or by the util?
error: http://pastebin.com/Bk7GvpMp
util: https://bukkit.org/threads/sign-gui-use-the-sign-interface-to-get-user-input.177030/
You're doing a great job on this plugin :D

@dmulloy2
Copy link
Owner Author

dmulloy2 commented Mar 8, 2016

@Litona Looks to be an issue with the Util.

@Ste3et
Copy link

Ste3et commented Mar 8, 2016

Hello @dmulloy2 i need your protocollib for my FurniturePlugin have you update the WrappedDataWatcher currently ?

@dmulloy2
Copy link
Owner Author

dmulloy2 commented Mar 8, 2016

@Ste3et The data watcher wrapper has been updated, although there are a lot of changes in 1.9.

@edasaki
Copy link

edasaki commented Mar 13, 2016

Hello, thanks so much for the updates! Are there any plans to update TinyProtocol? I seem to be getting some errors using it in 1.9 (with code that was functional in 1.8)

@macdja38
Copy link

@edasaki see the end of the list.

@axynos
Copy link

axynos commented Mar 20, 2016

ETA for 4.0.0?

@dmulloy2 dmulloy2 modified the milestones: 4.0.0, 3.7 Mar 20, 2016
@dmulloy2
Copy link
Owner Author

@axynos Hopefully soon, it's a large structural change.

@scrayos
Copy link

scrayos commented Mar 22, 2016

Just a quick reminder: While publishing 4.0.0 keep the generation of javadoc + sources in mind.

@Sikatsu
Copy link

Sikatsu commented Apr 8, 2016

It seems your jenkins is unavailable right now.

@Vinc0682
Copy link

Vinc0682 commented Apr 8, 2016

Really hoping for updated packet wrappers soon, will be able to update serveral plugins. Keep youre good work 😄

@dmulloy2
Copy link
Owner Author

dmulloy2 commented Apr 8, 2016

@Vinc0682 PacketWrapper has been updated: https://github.com/dmulloy2/PacketWrapper

@dmulloy2
Copy link
Owner Author

dmulloy2 commented Apr 8, 2016

@Sikatsu Should be back up, thanks!

@TNTUP
Copy link

TNTUP commented Apr 8, 2016

Can't wait for the final build to test (Stable one), the beta works well 👍

@Sikatsu
Copy link

Sikatsu commented Apr 8, 2016

Yup thanks :)

@edasaki
Copy link

edasaki commented Apr 15, 2016

Since TinyProtocol is coming up on the list of stuff to update, I was wondering if there is any chance at looking at a fix for reloading with TinyProtocol in use? I get this error when reloading with TinyProtocol: java.lang.IllegalArgumentException: Duplicate handler name: tiny-PluginName-2

I see the close() code being called, is there a step missing that's not fully removing the original handler?

Note that when I reload twice the error does not appear on the second refresh.

@dmulloy2
Copy link
Owner Author

@edasaki That's odd, it should remove the handler when it closes. The only thing I can think of is that it removes the handler in the channel thread, which is only an issue when reloading. Problems like these are why I don't recommend reloading.

@edasaki
Copy link

edasaki commented Apr 23, 2016

Ah I was being silly, it only happens when I replace the plugin jar with a newer version, so the classloader can't find the old version of the class lmao. There's no issue reloading normally, only when the jar is replaced before the reload (which I know is super bad practice but I only do it on dev server anyways so whatever :P) I guess it's not a problem.

@Permanently
Copy link

Almost done... 👍

@jwflory
Copy link

jwflory commented May 16, 2016

@dmulloy2++

Nice work, this is awesome to see hitting 4.0.0. :)

🎊 🎆 😄 🍰 🍬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests