Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickle CMSSW spec with protocolo=0 (and encode ?) #5054

Closed
belforte opened this issue Jul 2, 2021 · 5 comments
Closed

pickle CMSSW spec with protocolo=0 (and encode ?) #5054

belforte opened this issue Jul 2, 2021 · 5 comments

Comments

@belforte
Copy link
Member

belforte commented Jul 2, 2021

see

  • Force pickle protocol=0 for the spec creation to be compatible with Py2/Py3 (Alan Malta Rodrigues) #10628
  • Encode CMSSW picklearguments to bytes before loading it (Alan Malta Rodrigues) #10648

from
https://github.com/dmwm/WMCore/releases/tag/1.5.0

I do not know if we need for crab to make PSet.pkl in py3 and read in py2... but this is something to keep in mind as soon as we get over dmwm/CRABServer#6653 and start to actually run py3 payloads.

@belforte belforte added the Py2/3 label Jul 2, 2021
@belforte belforte self-assigned this Jul 2, 2021
@belforte
Copy link
Member Author

belforte commented Jul 2, 2021

refs:
dmwm/WMCore#10628
dmwm/WMCore#10648

@belforte belforte changed the title pickle CMSSW spec with protocolo=0 and encode ? pickle CMSSW spec with protocolo=0 (and encode ?) Jul 14, 2021
@belforte
Copy link
Member Author

We really should do it.

belforte added a commit to belforte/CRABClient that referenced this issue Aug 12, 2021
@belforte belforte added the Done label Aug 12, 2021
Make Python2/Python3 Compatible automation moved this from ToDo to Done Aug 13, 2021
@belforte belforte reopened this Aug 14, 2021
@belforte
Copy link
Member Author

belforte commented Aug 14, 2021

as @khurtado suggested, it would be better to use the ad-hoc common method
https://github.com/cms-sw/cmssw-wm-tools/blob/master/bin/edm_pset_pickler.py

@belforte
Copy link
Member Author

better to make a different issue about replacing "my code" with "common code" and keep this closed, since it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant