Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /etc/condor/condor_config to TW Fix #8497 #8499

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

belforte
Copy link
Member

No description provided.

@belforte belforte requested a review from novicecpp June 14, 2024 20:59
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2016/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member Author

thanks Wa. Sorry I had meant to explain why I asked for a review here but somehow it got lost. Of course the change in itself is a no-brainer, but I meant to let you comment on the specific way I implemented in Dockerfile. You made me worry about having too many RUN and hence too many layers and too large images. But I do not have a proper understanding.

@novicecpp
Copy link
Contributor

novicecpp commented Jun 18, 2024

You made me worry about having too many RUN and hence too many layers and too large images.

You understand it correctly. But this change is not much compare to largish pip install and gfal-* layer.
One thing you need to keep in mind is, make sure that when you create new directory and copy file has proper permission you want for service, avoid chmod like I do in cicd/crabtaskworker_pypi/Dockerfile#L134

@belforte belforte merged commit 3f893cf into dmwm:master Jun 18, 2024
2 checks passed
@belforte belforte deleted the add-condor_config-8497 branch June 20, 2024 09:38
belforte added a commit to belforte/CRABServer that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants