Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use simple py script as the entrypoint of TW process #8541

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Use simple py script as the entrypoint of TW process #8541

merged 1 commit into from
Jul 9, 2024

Conversation

novicecpp
Copy link
Contributor

Fix #8540

This PR introduce crab-taskworker file to act as binary of TW process, so when you run ./start.sh -g, python will read MasterWorker.py from GH instead of installation path.

The PR also deprecates the SequentialWorker.py and replaces it with the new option --pdb, running sequential mode the same way SequentialWorker.py does.

@novicecpp
fix TW entrypoint
fe2d140 
Use the same pattern as Rucio ASO script
@novicecpp novicecpp requested a review from belforte July 4, 2024 10:41
@novicecpp novicecpp self-assigned this Jul 4, 2024
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: failed
    • 6 warnings and errors that must be fixed
    • 5 warnings
    • 38 comments to review
  • Pycodestyle check: succeeded
    • 66 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2042/artifact/artifacts/PullRequestReport.html

@novicecpp novicecpp removed the request for review from belforte July 4, 2024 11:18
belforte
belforte approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I am really pleased that you managed to get rid of the code duplication in SequentialWorker

@novicecpp novicecpp changed the title Use simple py script as the main of TW process Use simple py script as the entrypoint of TW process Jul 5, 2024
@novicecpp
Copy link
Contributor Author

Thanks Stefano. Merging...

@novicecpp novicecpp merged commit 88794af into dmwm:master Jul 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belforte belforte belforte approved these changes

Assignees

@novicecpp novicecpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change entrypoint of TW process to simple binary script
3 participants
@novicecpp @cmsdmwmbot @belforte