Fix logic which drops input blocks to be transferred #10928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
test this please |
todor-ivanov
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Thanks for those changes @amaltaro They look OK to me. I have only one minor comment, which is not a show stopper here. It is about the new naming of the variables. I would rather call them: runAllowedList and runForbiddenList so that while reading later in the code one does not get the wrong impression it is a single valued item. The List suffix still marks the plural in the variable's nature :) But both ways would do I think. As you find it better.
|
Jenkins results:
|
rename variables with a List suffix
|
@todor-ivanov thanks for the review, Todor. Indeed renaming those variables will be better. I have just updated the code. |
|
Jenkins results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10927
Status
ready
Description
If we have a workflow, with either run or lumi list, and we happen to drop all the blocks from the initial input list, the initial list of blocks is kept and used for input data placement.
With this patch, if a workflow drops all the previously matched input blocks, it will pass an empty dictionary upstream which should not trigger any input data placement.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None