Add rse=ALL_DOCS to the MSUnmerged info REST API. #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
todor-ivanov
force-pushed
the
feature_MSUnmerged_RseAllDocsApi_fix_10995
branch
from
4391ccd
to
9b4abed
Compare
|
Jenkins results:
|
todor-ivanov
changed the title
amaltaro
approved these changes
Mar 7, 2022
| mongoProjection = { | ||
| "_id": False, | ||
| "name": True, | ||
| "isClean": True, |
There was a problem hiding this comment.
Don't you want to have rucioConMonStatus attribute on this query as well?
There was a problem hiding this comment.
That's a good idea actually. Let me add it into the projection before we merge. And I will also update the commit message.
Add type check of kwargs[rse]. Add rucioConMonStatus to the MongoDBProjection for rse=ALL_DOC.
todor-ivanov
force-pushed
the
feature_MSUnmerged_RseAllDocsApi_fix_10995
branch
from
9b4abed
to
d7e4714
Compare
|
Thanks for the quick review @amaltaro ! I just added |
|
Jenkins results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10995
Status
ready
Description
With the current PR we implement ad a simple addition of
rse=ALL_DOCSto the info REST API for MSUnmerged, so that we can get the counters for all the RSEs with thegfalerrors.NOTE:
This will not get the whole document stored in MongoDB. This interface is to serve only for collecting all
gfalerrors for all RSEs.Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None