Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how run number is defined for harvested root files in multiRun mode #9746

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/python/WMCore/JobSplitting/Harvest.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,15 @@ def createMultiRunJob(self, locationDict, location, baseName, harvestType, runDi
self.currentJob.addBaggageParameter("runIsComplete", True)
self.mergeLumiRange(self.currentJob['mask']['runAndLumis'])

# now calculate the minimum and maximum run number, it has to go to the root name
minRun = min(self.currentJob['mask']['runAndLumis'].keys())
maxRun = max(self.currentJob['mask']['runAndLumis'].keys())
# assume run_number 1 is MC (might - one day - no longer work)
if set(self.currentJob['mask']['runAndLumis'].keys()) == {1}:
forceRunNumber = 1
else:
# then it's data harvesting, force run number in runtime
forceRunNumber = 999999

self.currentJob.addBaggageParameter("multiRun", True)
self.currentJob.addBaggageParameter("runLimits", "-%s-%s" % (minRun, maxRun))
self.currentJob.addBaggageParameter("forceRunNumber", forceRunNumber)

return

Expand Down
14 changes: 5 additions & 9 deletions src/python/WMCore/WMRuntime/Scripts/SetupCMSSWPset.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,22 +538,18 @@ def handleDQMFileSaver(self):

runIsComplete = getattr(self.jobBag, "runIsComplete", False)
multiRun = getattr(self.jobBag, "multiRun", False)
runLimits = getattr(self.jobBag, "runLimits", "")
self.logger.info("DQMFileSaver set to multiRun: %s, runIsComplete: %s, runLimits: %s",
multiRun, runIsComplete, runLimits)
forceRunNumber = getattr(self.jobBag, "forceRunNumber", False)
self.logger.info("DQMFileSaver set to multiRun: %s, runIsComplete: %s, forceRunNumber: %s",
multiRun, runIsComplete, forceRunNumber)

self.process.dqmSaver.runIsComplete = cms.untracked.bool(runIsComplete)
if multiRun and isCMSSWSupported(self.getCmsswVersion(), "CMSSW_8_0_0"):
self.process.dqmSaver.forceRunNumber = cms.untracked.int32(999999)
if forceRunNumber:
self.process.dqmSaver.forceRunNumber = cms.untracked.int32(forceRunNumber)
if hasattr(self.step.data.application.configuration, "pickledarguments"):
args = pickle.loads(self.step.data.application.configuration.pickledarguments)
datasetName = args.get('datasetName', None)
if datasetName:
if multiRun:
# then change the dataset name in order to get a different root file name
datasetName = datasetName.rsplit('/', 1)
datasetName[0] += runLimits
datasetName = "/".join(datasetName)
self.process.dqmSaver.workflow = cms.untracked.string(datasetName)
return

Expand Down
2 changes: 1 addition & 1 deletion test/python/WMCore_t/JobSplitting_t/Harvest_t.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def testMultiRunHarvesting(self):
for job in jobGroup.jobs:
baggage = job.getBaggage()
self.assertTrue(getattr(baggage, "multiRun", False), "It's supposed to be a multiRun job")
self.assertEqual(getattr(baggage, "runLimits", ""), "-1-6")
self.assertEqual(getattr(baggage, "forceRunNumber", False), 999999)

def testByRunHarvesting(self):
"""
Expand Down