board3 edit #42
board3 edit #42
Conversation
|
Wow, this looks like it has been quite an effort! I do wonder though whether merging this is a good idea as mChat would directly depend on the board3 portal extension. If they update their code and something breaks with the mChat integration, mChat is forced to be updated as well. Briefly glancing over the changes it looks like it could be packaged into an entirely separate "brigde extension". @talonos, do you think such a "bridge extension" would be possible, provided all the necessary events are added to mChat? |
|
the edits don't require board3 to be installed as the code looks to see what page is loaded and portal code is only loaded if portal is present. otherwise it only loads on index. give it a try on a test forum without board3 and its no different from the master here. |
That's a good thing but it doesn't solve the problem of a breaking change in the portal extension. It's rather another reason to create a separate extension for it, in my opinion. The majority of users don't use the portal I presume, they don't need these code edits. Forcing them to update their mChat because of a feature they don't use is not very user-friendly. |
edited 0.3.4 to make it also work with board3.de portal extension.