Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple Dynamics values per DirectionType #130

Closed
jsbean opened this issue Oct 11, 2019 · 1 comment · Fixed by #157
Closed

Allow multiple Dynamics values per DirectionType #130

jsbean opened this issue Oct 11, 2019 · 1 comment · Fixed by #157
Labels
bug Something isn't working

Comments

@jsbean
Copy link
Member

jsbean commented Oct 11, 2019

The DirectionType.dynamics case currently holds onto a single Dynamics as its associated value.

In the MusicXML spec, however, there should be able to be a sequence of Dynamics values. In #126, we were able to decode a single Dynamics value, which seems to be the vastly more common case.

@DJBen, @bwetherfield, let me know if you've got thoughts on how to deal with this.
@jsbean jsbean added the bug Something isn't working label Oct 11, 2019
@jsbean
Copy link
Member Author

jsbean commented Oct 11, 2019

The same problem occurs with coda, and rehearsal.

@jsbean jsbean mentioned this issue Oct 11, 2019
Merged
bwetherfield added a commit that referenced this issue Oct 14, 2019
@bwetherfield
Remove FIXME #130 notes
2299596
@bwetherfield bwetherfield mentioned this issue Oct 14, 2019
Merged
bwetherfield added a commit that referenced this issue Oct 14, 2019
@bwetherfield
Dynamics array fix (#157)
995d9f6 
* Add Dynamics array fix

* Extend fix to words, rehearsal marks, percussion

* Add multiple words test

* Add test case for multiple rehearsal marks

* Extend fix to coda

* Remove FIXME #130 notes

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamics array fix dn-m/MusicXML
1 participant
@jsbean