-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Stabat Mater test #126
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #126 +/- ##
==========================================
+ Coverage 57.67% 60.11% +2.43%
==========================================
Files 218 219 +1
Lines 2800 2911 +111
==========================================
+ Hits 1615 1750 +135
+ Misses 1185 1161 -24
Continue to review full report at Codecov.
|
@DJBen, @bwetherfield, I need to bail for the evening. I am also a bit stuck on this one. If either of you want to pick this up, that would be great! This will require getting the |
@DJBen, @bwetherfield, this fix constrains things a little bit more than the spec re: In the spec, a Several LilyPond tests are fixed by this, so I am ok with this being a stop-gap solution. There is a |
@@ -36,5 +38,44 @@ public enum Dynamic: String { | |||
//case other(OtherDynamics) | |||
} | |||
|
|||
extension Dynamic: XMLChoiceCodingKey { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long live XMLChoiceCodingKey
.
This PR fixes the Schubert Stabat Mater LilyPond test. Down to 51 LilyPond test failures.