Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-a (for 'select all') doesn't select all results #508

Closed
oddwing opened this issue May 27, 2021 · 3 comments
Closed

Ctrl-a (for 'select all') doesn't select all results #508

oddwing opened this issue May 27, 2021 · 3 comments
Labels

Comments

@oddwing
Copy link

oddwing commented May 27, 2021

When I press Ctrl-a to select all of my search results, only the first two page lengths are selected (around 58 results). If I page down twice and hit Ctrl-a again, the next two page lengths are selected. To truly select all search results, I have to page through all of the results. This gets tedious when there are many results.

@doug24
Copy link
Contributor

doug24 commented May 28, 2021

Yes, that is a bug. When you do first select all, it's only getting the current set of tree nodes. The search results tree dynamically creates and removes tree nodes as you scroll to save memory and improve performance. This is done to protect against creating large numbers of tree nodes, which can lock up the app. Not sure what the best way to fix this.

Just wondering if there is another solution to the problem: after you select all, what are you doing with the selected items?

@doug24 doug24 added the bug label May 28, 2021
@doug24
Copy link
Contributor

doug24 commented Jun 2, 2021

Does anyone have an opinion of what "Select all" means?

The search results is a tree, with the file at the top level, and the set of matches within the file at the child level. Can we say that "Select all" means all the file nodes, but doesn't include the collection of all child nodes?

@doug24
Copy link
Contributor

doug24 commented Jun 27, 2021

Fixed in Release 2.9.345

I decided to make 'Select all' select all the file level tree nodes and also select all the line results, if they are expanded in the tree. I think this gives the user the most control over what information is selected.

Because the line level results are lazy loaded in the tree, I did not want Select all to force loading all the line results just to select them. But if you need to, you can expand all the nodes and then select all.

@doug24 doug24 closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants