localized badge labels and tooltips, fixes #28

dnbard · Jul 19, 2014 · 824f3c2 · 824f3c2
1 parent 359e99e
commit 824f3c2
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 5 deletions.
diff --git a/extension/achievements/adobe.js b/extension/achievements/adobe.js
@@ -2,6 +2,7 @@ define(function(require, exports, module){
     var Achievement = require('./achievement'),
         config = require('../config'),
         _ = require('../vendor/lodash.min'),
+        locale = require('../services/locale'),
         ExtensionsService = require('../services/extensions');
 
     function AdobeAchievement(){
@@ -15,7 +16,10 @@ define(function(require, exports, module){
         }
 
         this.getTag = function(rating, element){
-            return '<span title="Extension from Adobe" class="ext-badge ext-badge-adobe">Adobe</span>';
+            return _.template('<span title="${title}" class="ext-badge ext-badge-adobe">${badge}</span>',{
+                badge: locale.get('badgeAdobe'),
+                title: locale.get('badgeAdobeTitle')
+            });
         }
     }
 

diff --git a/extension/achievements/memorial.js b/extension/achievements/memorial.js
@@ -2,8 +2,14 @@ define(function(require, exports, module){
     var Achievement = require('./achievement'),
         config = require('../config'),
         _ = require('../vendor/lodash.min'),
+        locale = require('../services/locale'),
         dictionary = {
-            'themesforbrackets': { tag: '<span title="First extension that have 100k downloads" class="ext-badge ext-badge-100k">100k Downloads</span>' }
+            'themesforbrackets': {
+                tag: _.template('<span title="${title}" class="ext-badge ext-badge-100k">${badge}</span>',{
+                    title: locale.get('badge100kTitle'),
+                    badge: locale.get('badge100k')
+                })
+            }
         };
 
     function MemorialAchievement(){

diff --git a/extension/achievements/mostDownloads.js b/extension/achievements/mostDownloads.js
@@ -2,6 +2,7 @@ define(function(require, exports, module){
     var Achievement = require('./achievement'),
         config = require('../config'),
         _ = require('../vendor/lodash.min'),
+        locale = require('../services/locale'),
         numberOfTopExtensoins = 7;
 
     function MostDownloadsAchievement(){
@@ -21,7 +22,10 @@ define(function(require, exports, module){
         }
 
         this.getTag = function(rating){
-            return '<span title="Most popular extension" class="ext-badge ext-badge-top">Top</span>';
+            return _.template('<span title="${title}" class="ext-badge ext-badge-top">${badge}</span>',{
+                badge: locale.get('badgeTop'),
+                title: locale.get('badgeTopTitle')
+            });
         }
     }
 

diff --git a/extension/achievements/mostTrending.js b/extension/achievements/mostTrending.js
@@ -2,6 +2,7 @@ define(function(require, exports, module){
     var Achievement = require('./achievement'),
         config = require('../config'),
         _ = require('../vendor/lodash.min'),
+        locale = require('../services/locale'),
         numberOfTrendingExtensions = 7;
 
     function MostTrendingAchievement(){
@@ -21,7 +22,10 @@ define(function(require, exports, module){
         }
 
         this.getTag = function(rating){
-            return '<span title="Most trending extension" class="ext-badge ext-badge-trend">Trending</span>';
+            return _.template('<span title="${title}" class="ext-badge ext-badge-trend">${badge}</span>',{
+                badge: locale.get('badgeTrend'),
+                title: locale.get('badgeTrendTitle')
+            });
         }
     }
 

diff --git a/extension/achievements/new.js b/extension/achievements/new.js
@@ -2,6 +2,7 @@ define(function(require, exports, module){
     var Achievement = require('./achievement'),
         config = require('../config'),
         _ = require('../vendor/lodash.min'),
+        locale = require('../services/locale'),
         ExtensionsService = require('../services/extensions');
 
     function UpdatedAchievement(){
@@ -24,7 +25,10 @@ define(function(require, exports, module){
         }
 
         this.getTag = function(rating, element){
-            return '<span title="New extension" class="ext-badge ext-badge-new">New</span>';
+            return _.template('<span title="${title}" class="ext-badge ext-badge-new">${badge}</span>',{
+                badge: locale.get('badgeNew'),
+                title: locale.get('badgeNewTitle')
+            });
         }
     }
 

diff --git a/extension/locale/en-US.js b/extension/locale/en-US.js
@@ -16,6 +16,23 @@ define(function (require, exports, module){
         name: 'Name',
         daily: 'downloads yesterday', //0.3.0
 
+        /*BADGES*/
+        badgeAdobe: 'Adobe',
+        badgeAdobeTitle: 'Extension from Adobe',
+
+        badge100k: '100k Downloads',
+        badge100kTitle: 'First extension that had 100k downloads',
+
+        badgeTop: 'Top',
+        badgeTopTitle: 'Most popular extension',
+
+        badgeTrend: 'Trending',
+        badgeTrendTitle: 'Most trending extension',
+
+        badgeNew: 'New',
+        badgeNewTitle: 'New extension',
+        /*END of BADGES*/
+
         //Detailed info about ##
         'click-more': 'Detailed info about', //0.3.0