Skip to content

Commit

Permalink
sort extensions by stars and forks count, fix #42
Browse files Browse the repository at this point in the history
  • Loading branch information
dnbard committed Jul 20, 2014
1 parent 3089813 commit 9805b5f
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 2 deletions.
4 changes: 3 additions & 1 deletion extension/locale/en-US.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ define(function (require, exports, module){
trending: 'Trending', //0.3.0
name: 'Name',
daily: 'downloads yesterday', //0.3.0
stars: 'Stars', //0.4.0
forks: 'Forks', //0.4.0

/*BADGES*/
/*BADGES - 0.3.2*/
badgeAdobe: 'Adobe',
badgeAdobeTitle: 'Extension from Adobe',

Expand Down
16 changes: 15 additions & 1 deletion extension/services/mutation.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ define(function (require, exports, module){
downloads: locale.get('downloads'),
update: locale.get('update'),
trending: locale.get('trending'),
name: locale.get('name')
name: locale.get('name'),
stars: locale.get('stars'),
forks: locale.get('forks')
});

function init(){
Expand Down Expand Up @@ -135,6 +137,8 @@ define(function (require, exports, module){

$t.attr('data-extension-loads', totalDownloads);
$t.attr('data-extension-yesterday', dailyDownloads? dailyDownloads : 0);
$t.attr('data-extension-stars', stars);
$t.attr('data-extension-forks', forks);
});
}

Expand Down Expand Up @@ -254,6 +258,16 @@ define(function (require, exports, module){
return elements = _.sortBy(elements, function(el){
return -parseInt($(el).attr('data-extension-yesterday'));
});
},
'stars' : function(elements){
return elements = _.sortBy(elements, function(el){
return -parseInt($(el).attr('data-extension-stars'));
});
},
'forks' : function(elements){
return elements = _.sortBy(elements, function(el){
return -parseInt($(el).attr('data-extension-forks'));
});
}
}

Expand Down
2 changes: 2 additions & 0 deletions extension/templates/sortButton.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<option>${sortby}</option>
<option value="author">${author}</option>
<option value="downloads">${downloads}</option>
<option value="forks">${forks}</option>
<option value="name">${name}</option>
<option value="trending">${trending}</option>
<option value="stars">${stars}</option>
<option value="update">${update}</option>
</select>

0 comments on commit 9805b5f

Please sign in to comment.