New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Breadcrumb): Allow Breadcrumb to get skeleton prop from context #1349
Merged
langz
merged 2 commits into
main
from
fix/allow-breadcrumb-to-get-skeleton-prop-from-context
Mar 14, 2022
Merged
fix(Breadcrumb): Allow Breadcrumb to get skeleton prop from context #1349
langz
merged 2 commits into
main
from
fix/allow-breadcrumb-to-get-skeleton-prop-from-context
Mar 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b78d9a3:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
dinarosv
approved these changes
Mar 14, 2022
dinarosv
force-pushed
the
fix/allow-breadcrumb-to-get-skeleton-prop-from-context
branch
from
March 14, 2022 14:00
a2f0d0d
to
b78d9a3
Compare
langz
deleted the
fix/allow-breadcrumb-to-get-skeleton-prop-from-context
branch
March 14, 2022 18:47
tujoworker
pushed a commit
that referenced
this pull request
Apr 5, 2022
# [9.25.0](v9.24.0...v9.25.0) (2022-04-05) ### Bug Fixes * **Anchor:** Missing properties in PropTypes ([#1382](#1382)) ([92b6615](92b6615)) * **Avatar:** Allow Avatar to get skeleton prop from context ([#1347](#1347)) ([386616b](386616b)) * **Avatar:** Allow Avatar.Group to set skeleton prop ([#1350](#1350)) ([a0d4e8a](a0d4e8a)) * **Breadcrumb:** Allow Breadcrumb to get skeleton prop from context ([#1349](#1349)) ([b46f83b](b46f83b)) * **Button:** make tertiary button icon inherit button height property ([04111d5](04111d5)) * **Button:** remove outline when button goes from enabled to disabled state when activeElement ([8f40076](8f40076)) * declare v17 as Eufemias peer dependency ([b14d237](b14d237)) * **Dialog:** prevent close confirmation dialog on outside click ([d391285](d391285)) * **Dropdown:** ensure the ellipsis text overflow works again ([640bdf9](640bdf9)) * **FormStatus:** wider the min-width to 30rem and react on window width change ([adb2f3f](adb2f3f)) * **Hr:** ensure the hr element does not causing a scrollbar ([cca94ff](cca94ff)) * **InfoCard:** Allow InfoCard to get skeleton prop from context ([#1348](#1348)) ([e2290c2](e2290c2)) * **Modal:** containerPlacement bug for top ([5864004](5864004)) * **Pagination:** add better experience for small viewports ([28ad651](28ad651)) * **Pagination:** handle unknown / undefined page_count ([acc9c81](acc9c81)) * **Pagination:** updated media query calculation ([35344ea](35344ea)) * **Pagination:** use primary-icon instead of secondary import ([6944863](6944863)) * remove alignment helpers from a11y tree (NVDA & Firefox) ([f31be33](f31be33)) * **Skeleton:** Missing properties in PropTypes ([#1381](#1381)) ([9abc790](9abc790)) * **Tag:** Allow Tag to get skeleton prop from context ([3723421](3723421)) * **Tag:** Allow Tag.Group to set skeleton prop ([#1351](#1351)) ([844e215](844e215)) * **Tag:** avoid inheriting spacing props when set on Tag.Group ([fbb7ad1](fbb7ad1)) * **Theming:** simplify the theming logic ([9b50082](9b50082)) * **Timeline:** Allow Timeline to get skeleton prop from context ([#1346](#1346)) ([b87a59a](b87a59a)) * **Tooltip:** ensure portal element does not occupy space in body ([4b05280](4b05280)) * **Tooltip:** fix premature removal of portal and prevent zombies ([fb0fe33](fb0fe33)) * **Typography:** fix lead element and update docs ([3274dfe](3274dfe)) * **VisuallyHidden:** use span as default element so it can be used inside paragraphs ([8dbc8a3](8dbc8a3)) ### Features * add useNumberFormat hook ([b218d27](b218d27)) * **Drawer:** less spacing in new styles ([c4faaf2](c4faaf2)) * **Eiendom:** apply theme styles ([447ccd6](447ccd6)) * **helpers:** add cancel method to debounce ([19cb3e0](19cb3e0)) * **Icons:** add account_percent, news, podcast, user_feedback ([8695f57](8695f57)) * **Icons:** rebuild all icons from refactored Figma lib source ([fc952bb](fc952bb)) * **Modal:** add property omitTriggerButton for hiding default trigger ([26e90fb](26e90fb)) * **Modal:** add property omitTriggerButton for hiding default trigger ([d02bbdd](d02bbdd)) * **Pagination:** enhance accessibility and align styles to UX ([6fdba78](6fdba78)) * **Pagination:** moved next buttons in new design ([d516264](d516264)) * **Portal:** Suffix page titles with "| Eufemia" ([#1333](#1333)) ([788a58b](788a58b)) * **Theme:** add visual test example for Eiendom theme ([dcf918b](dcf918b)) * **Theme:** create Eufemia Theme handler (Gatsby Plugin) ([d257a55](d257a55))
🎉 This PR is included in version 9.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #1344