Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): Allow Tag to get skeleton prop from context #1344

Merged

Conversation

eivindfjeldstad
Copy link
Contributor

@eivindfjeldstad eivindfjeldstad commented Mar 9, 2022

Summary

Allow Tag to inherit skeleton prop from context.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3723421:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 9, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 9m

Performance

Lighthouse report

Metric Score
Performance 🔶 63
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@tujoworker tujoworker self-requested a review March 9, 2022 13:28
@tujoworker tujoworker force-pushed the fix/allow-tag-to-get-skeleton-prop-from-context branch from c8470db to 3723421 Compare March 9, 2022 13:42
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you 🙌

I added a quick test to verify this 👍

@tujoworker
Copy link
Member

🎉 This PR is included in version 9.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants