Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HeightAnimation): ensure Radio buttons persist their state #3535

Merged
merged 1 commit into from
May 7, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented May 7, 2024

Why it effects radio buttons: The name attribute is used to create a "group". But when a new element gets added, that has the same name, it conflicts with the existing group, and removes the checked state of the current checked radio button, as there is a second "checked" one.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 4:36pm

Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker merged commit 3e78976 into main May 7, 2024
15 checks passed
@tujoworker tujoworker deleted the fix/height-animation-radio-button branch May 7, 2024 19:46
tujoworker pushed a commit that referenced this pull request May 7, 2024
## [10.29.0](v10.28.0...v10.29.0) (2024-05-07)

### 📝 Documentation

* **InputMasked:** fix import path of MultiInputMask ([#3469](#3469)) ([b678412](b678412))

### ✨ Features

* **forms:** add `autocomplete` variant to Field.Selection with `autocompleteProps` support ([#3521](#3521)) ([f79dd16](f79dd16))
* **forms:** add `Field.Name` and `Value.Name` ([#3528](#3528)) ([84fcce1](84fcce1)), closes [#3529](#3529)
* **forms:** add `transformIn` and `transformOut` to Form.Handler ([#3511](#3511)) ([48959b2](48959b2))
* **forms:** add `Value.OrganizationNumber` ([#3525](#3525)) ([46ff116](46ff116))
* **forms:** add `Value.PostalCodeAndCity` ([#3527](#3527)) ([adb4cf5](adb4cf5))
* **forms:** add Wizard transition animation ([#3517](#3517)) ([c42dab7](c42dab7))
* **forms:** debounce session data storing to enhance performance ([#3508](#3508)) ([6aeaa96](6aeaa96))
* **forms:** rename Form.Handler property `filterData` to `filterSubmitData` (deprecate) ([#3507](#3507)) ([b7aa69b](b7aa69b))
* **ProgressIndicator:** add `countdown` type, center label, and customization options ([#3487](#3487)) ([c29be5e](c29be5e))

### 🐛 Bug Fixes

* **forms:** (TypeScript) ensure `data` type is inherited in onSubmit ([#3530](#3530)) ([a5e63ad](a5e63ad))
* **forms:** align form error when Wizard Sidebar is visible ([#3518](#3518)) ([bb6feab](bb6feab))
* **forms:** enhance Radio buttons disabled state handling ([#3533](#3533)) ([1932143](1932143))
* **forms:** ensure inline values don't show labels ([#3529](#3529)) ([b4dff2b](b4dff2b))
* **forms:** fix spacing between checkboxes when in horizontal layout with vertical options ([#3531](#3531)) ([193d94f](193d94f))
* **HeightAnimation:** ensure Radio buttons persist their state ([#3535](#3535)) ([3e78976](3e78976))
* **Locale:** revert to less strict local types (`string`) ([#3526](#3526)) ([aa79867](aa79867))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants