Introduce Hosted Support #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tduffield
force-pushed
the
s3-file-support
branch
2 times, most recently
from
456ed92
to
5a28b28
Compare
tduffield
force-pushed
the
s3-file-support
branch
from
5a28b28
to
7e1e802
Compare
tduffield
force-pushed
the
s3-file-support
branch
5 times, most recently
from
6636e24
to
c9ebd8e
Compare
|
Alright, fully rebased with unit and functional tests! |
tduffield
force-pushed
the
s3-file-support
branch
from
c9ebd8e
to
f29cbf3
Compare
|
I'm not sure when I will be able to give it a full review and try it out, but I wanted to say that it looks pretty cool. Thanks for working on it! |
tduffield
force-pushed
the
s3-file-support
branch
2 times, most recently
from
0f0c486
to
995a7c7
Compare
Hosted support optimizes the behavior of Dobi for a hosted CI environment such as Jenkins, TravisCI, CircleCI, or Buildkite. Hosted Mode changes two key behaviors: 1. We use `git` rather than the file modification time to determine when a file has last been modified. 2. Since the Dobi records in `.dobi` need to be stored outside of the workspace, the `LastModified` value is kept inside the record, rather than being determined based on the file modification time. To enable Hosted Mode, simply set `DOBI_HOSTED` to any value. You can also set `meta.hosted` to `true` in your Dobi YAML. Signed-off-by: Tom Duffield <tom@chef.io> Signed-off-by: Tom Duffield <github@tomduffield.com>
We don't need it, and it causes the linuxkit-rtf dependencies to be added to go.mod and go.sum. Signed-off-by: Tom Duffield <tom@chef.io>
Signed-off-by: Tom Duffield <github@tomduffield.com>
|
@dnephin I've rebased and updated my PR based on your most recent changes. I'd love to see if we can get this into the upstream so I can avoid having to maintain a fork. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosted support optimizes the behavior of Dobi for a hosted CI environment such as Jenkins, TravisCI, CircleCI, or Buildkite.
Hosted Mode changes two key behaviors:
gitrather than the file modification time to determine when a file has last been modified..dobineed to be stored outside of the workspace, theLastModifiedvalue is kept inside the record, rather than being determined based on the file modification time.To enable Hosted Mode, simply set
DOBI_HOSTEDto any value. You can also setmeta.hostedtotruein your Dobi YAML.Closes #182.