Fix image pull with private repo #25

dnephin · 2016-10-03T15:48:15Z

Fixes #24

adds a validation error if the image field includes a tag
sends the correct registry auth for private registries (kind of). It won't send the hub auth now. I'm not sure if setting v1 as the path is exactly right, or if it needs to check both v1 and v2 paths.

dnephin · 2016-10-03T15:48:52Z

cc @bfirsh this seems to fix the issue for me. I'll have to test some more with private registries that actually require auth

Signed-off-by: Daniel Nephin <dnephin@gmail.com>

dnephin · 2016-10-03T19:21:50Z

Tests are green so going to merge this

dnephin added the kind/bug label Oct 3, 2016

dnephin added 2 commits October 3, 2016 11:51

Error if the image field contains a tag.

9d8b0f0

Signed-off-by: Daniel Nephin <dnephin@gmail.com>

Send correct auth for private registry

45217f5

Signed-off-by: Daniel Nephin <dnephin@gmail.com>

dnephin force-pushed the fix-image-pull-with-private-repo branch from 68efced to 45217f5 Compare October 3, 2016 15:51

dnephin added this to the 0.7 milestone Oct 3, 2016

dnephin merged commit 31f60b1 into master Oct 3, 2016

dnephin deleted the fix-image-pull-with-private-repo branch October 3, 2016 19:21

Provide feedback