Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pre-commit exclude #65

Merged
merged 1 commit into from
Nov 21, 2020
Merged

support pre-commit exclude #65

merged 1 commit into from
Nov 21, 2020

Conversation

callofdutyops
Copy link
Contributor

No description provided.

@dnephin
Copy link
Owner

dnephin commented Nov 15, 2020

Thank you for the PR! Could you please give some more information about what problem this change fixes?

@callofdutyops
Copy link
Contributor Author

callofdutyops commented Nov 16, 2020 •
edited

Thank you for the PR! Could you please give some more information about what problem this change fixes?

Hi, dnephin.
The original exec gocritic check ./... command will ignore the exclude settings in .pre-commit-config.yaml

dnephin
dnephin approved these changes Nov 21, 2020
View reviewed changes
Copy link
Owner

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i see it now. Thank you for the PR!

@dnephin dnephin merged commit ac0f658 into dnephin:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@callofdutyops @dnephin