Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error messages when the command expected is not available #85

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

ccoVeille
Copy link
Contributor

this avoids silent issues that may let think that everything is ok

fixes #71

This is an improvement for what was made with #69

this avoids silent issues that may let think that everything is ok
Copy link
Owner

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

run-go-critic.sh Outdated Show resolved Hide resolved
@dnephin dnephin merged commit 853aa23 into dnephin:master Mar 31, 2022
@@ -1,2 +1,9 @@
#!/usr/bin/env sh

if command -v golangci-lint &> /dev/null ; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops, did I merge this too quickly? Should these be ! command -v ? I'll fix this in a follow up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad, and thanks

@dnephin dnephin mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] goimports: command not found
2 participants