Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-generate for multiple directories #92

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

burik666
Copy link
Contributor

@burik666 burik666 commented Aug 12, 2022

If you change files in multiple directories, go generate will return an error.

named files must all be in one directory; have foo and bar

Issue #76

Copy link
Owner

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I believe this should fix the problem, but now that we have a pipe, I guess this script probably needs

set -eu -o pipefail

To ensure that the exit code is correct. What do you think?

@burik666
Copy link
Contributor Author

@dnephin, you're right, fixed.

@dnephin dnephin merged commit 74f6978 into dnephin:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants