Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Delete style overflow after closing PersonaBar #1151

Conversation

tingung
Copy link
Contributor

@tingung tingung commented Sep 12, 2019

Fixes #1030

Summary

  • Remove 'overflow' property instead change to 'auto'

Tested with all major browsers with latest version. (IE11, Google Chrome 76, Firefox 69, Edge 78)

Confirmation video - https://drive.google.com/file/d/1xZsGKRXLNfWQpuX5FTsM4Vihzmor6188/view

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas modified the milestones: 9.4.1, 10.0.0 Sep 17, 2019
@valadas
Copy link
Contributor

valadas commented Sep 17, 2019

@tingung this is targetting development which means it would go for Dnn 10, would you like to resubmit this targetting release/3.0.x so it gets in Dnn 9.4.1 ?

@tingung
Copy link
Contributor Author

tingung commented Sep 18, 2019

@valadas , let me check with stack holder and see if they would like to have it in 9.4.x.

@daguiler , what do you think?

@daguiler
Copy link
Contributor

Sounds like a bugfix, so I would say 9.4.1

@tingung
Copy link
Contributor Author

tingung commented Sep 18, 2019

Closing this PR - PR created for 3.0.x release target here - #1164

@tingung tingung closed this Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersonaBar closing action does not reset <body> overflow value properly
3 participants