Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Bump raw-loader from 0.5.1 to 2.0.0 #917

Merged
merged 2 commits into from May 8, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 7, 2019

Bumps raw-loader from 0.5.1 to 2.0.0.

Release notes

Sourced from raw-loader's releases.

v2.0.0

2.0.0 (2019-03-18)

Features

  • use ES Module export instead of CommonJS (#69) (3c7bf2c)

BREAKING CHANGES

  • use ES Module export instead of CommonJS (#69) (3c7bf2c)

v1.0.0

1.0.0 (2018-12-10)

Bug Fixes

Features

v1.0.0-beta.0

2017-10-02

Bug Fixes

  • escape newline/paragraph separators (#36) (c972c92)

Code Refactoring

BREAKING CHANGES

  • ES Modules are not compatible with webpack v1.0.0
Changelog

Sourced from raw-loader's changelog.

2.0.0 (2019-03-18)

Features

  • use ES Module export instead of CommonJS (#69) (3c7bf2c)

BREAKING CHANGES

  • use ES Module export instead of CommonJS (#69) (3c7bf2c)

1.0.0 (2018-12-10)

Bug Fixes

Features

BREAKING CHANGES

  • minimum require webpack version is 4
  • minimum require nodejs version is 6.9
Commits
Maintainer changes

This version was pushed to npm by evilebottnawi, a new releaser for raw-loader since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 7, 2019
@bdukes
Copy link
Contributor

bdukes commented May 7, 2019

This is being used in a number of components to read an SVG file, e.g.

const SimpleType = require(`!raw-loader!./svg/vocabulary_simple.svg`);
const HierarchyType = require(`!raw-loader!./svg/vocabulary_hierarchy.svg`);

(there are quite a few in this format ☝️)
<div dangerouslySetInnerHTML={{ __html: require("!raw-loader!./../../../img/fetching.svg") }} />

(a couple like this ☝️)
return require("!raw-loader!../../../img/common/" + props.type.toLowerCase() + ".svg");

(and also this one dynamic one ☝️)

webpack-contrib/raw-loader#69 indicates that these will need to change from

const example = require(`!raw-loader!./path.svg`)

to either of the following:

const example = require(`!raw-loader!./path.svg`).default

or

const { default: example } = require(`!raw-loader!./path.svg`);

@ohine
Copy link
Contributor

ohine commented May 7, 2019

@bdukes Any idea why CI passed? Shouldn't it of caught those required changes?

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/raw-loader-2.0.0 branch 3 times, most recently from 9bde71d to 16ad2ae Compare May 7, 2019 15:46
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/raw-loader-2.0.0 branch from 16ad2ae to d41bfcb Compare May 7, 2019 16:06
@bdukes
Copy link
Contributor

bdukes commented May 7, 2019

@ohine I think those would only be runtime issues, and I'd guess it fails silently even if those components are run by a test suite.

@mtrutledge
Copy link
Contributor

Could also be that there aren't any tests around the components that are doing the raw loading

@mtrutledge
Copy link
Contributor

I checked out this PR and added .default to the items that were doing require(...svg)

@mtrutledge mtrutledge added this to the 3.0.0 milestone May 7, 2019
@mtrutledge mtrutledge merged commit 5e50af5 into development May 8, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/raw-loader-2.0.0 branch May 8, 2019 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants