Improve user feedback for cleanup node in installer #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mitchelsellers
approved these changes
Aug 6, 2018
There was a problem hiding this comment.
Upon further review detailed logging will be a bigger change. The more appropriate change here is to improve the behavior which this does so approving as is.
@donker please sign the CLA.
|
Ultimately the try-catch shouldn't be around the entire cleanup file as it is now. It should be on each line. But I didn't want to create any risk with this change of changing behavior. So left that as is for now. |
bdukes
requested changes
Aug 16, 2018
| @@ -75,7 +75,7 @@ private bool ProcessCleanupFile() | |||
| } | |||
| catch (Exception ex) | |||
| { | |||
| Log.AddFailure(ex); | |||
| Log.AddWarning(string.Format(Util.CLEANUP_ProcessComplete, ex.Message)); | |||
There was a problem hiding this comment.
is this supposed to be using the CLEANUP_ProcessError field you defined below?
bdukes
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing an install as having an error, failing to clean up a file/folder should show a warning as it is not fatal to the installation of an extension.
Fix #2206