DNN-5206: DotNetNuke.Services.FileSystemFileManager.WriteFileToHttpContext(): Do not send negative "Content-Length" header #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o not send negative "Content-Length" header
jbrinkman
added
Community
cnurse
added a commit
that referenced
this pull request
Mar 13, 2015
DNN-5206: DotNetNuke.Services.FileSystemFileManager.WriteFileToHttpContext(): Do not send negative "Content-Length" header
valadas
pushed a commit
to valadas/Dnn.Platform
that referenced
this pull request
Oct 2, 2019
PB > Security: bugfix and optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the problem, that files > 2GB are not downloadable using the with LinkClick.aspx.
Please note: The problem, that the file size are negative for large files (due too integer overflow) is not fixed in the pull request. This requires changing the API (see @cathalconnolly comments here https://dnntracker.atlassian.net/browse/DNN-5206)