DNN-6265 Update OAuthClientBase to support optional parameters #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated OAuthClientBase to support the optional parameter "resource" of the OAuth V2 standard, as this field is required to support the Microsoft Azure Active Directory OAuth implementation. Also added UrlEncode logic to the APISecret, as apparently secret keys generated by Azure are not url friendly. Tested implementation on dev box and an Azure site for LiveConnect, Google, Facebook and Azure Active Directory.
|
Looks like I left off the bug number in the title. It is DNN-6265 |
skydnn
changed the title
|
thanks -we're in code-freeze for 7.4.0, so this will be processed for the 7.4.1 release |
jbrinkman
added
Community
cathalconnolly
pushed a commit
that referenced
this pull request
Mar 14, 2015
DNN-6265 Update OAuthClientBase to support optional parameters
|
I'm having issues integrating UseOpenIdConnectAuthentication to Azure (from Owin startup class). |
|
@tatigo it looks like this change was included in 7.4.1, so if you're planning to use DNN's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated OAuthClientBase to support the optional parameter "resource" of the OAuth V2 standard, as this field is required to support the Microsoft Azure Active Directory OAuth implementation.
Also added UrlEncode logic to the APISecret, as apparently secret keys generated by Azure are not url friendly.
Tested implementation on dev box and an Azure site for LiveConnect, Google, Facebook and Azure Active Directory.