New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN-6265 Update OAuthClientBase to support optional parameters #250

Merged
merged 1 commit into from Mar 14, 2015

Conversation

Projects
None yet
5 participants
@skydnn
Contributor

skydnn commented Dec 28, 2014

Updated OAuthClientBase to support the optional parameter "resource" of the OAuth V2 standard, as this field is required to support the Microsoft Azure Active Directory OAuth implementation.
Also added UrlEncode logic to the APISecret, as apparently secret keys generated by Azure are not url friendly.
Tested implementation on dev box and an Azure site for LiveConnect, Google, Facebook and Azure Active Directory.

Update OAuthClientBase to support optional parameters
Updated OAuthClientBase to support the optional parameter "resource" of the OAuth V2 standard, as this field is required to support the Microsoft Azure Active Directory OAuth implementation.
Also added UrlEncode logic to the APISecret, as apparently secret keys generated by Azure are not url friendly. 
Tested implementation on dev box and an Azure site for LiveConnect, Google, Facebook and Azure Active Directory.
@skydnn

This comment has been minimized.

Show comment
Hide comment
@skydnn

skydnn Jan 7, 2015

Contributor

Looks like I left off the bug number in the title. It is DNN-6265

Contributor

skydnn commented Jan 7, 2015

Looks like I left off the bug number in the title. It is DNN-6265

@skydnn skydnn changed the title from Update OAuthClientBase to support optional parameters to DNN-6265 Update OAuthClientBase to support optional parameters Jan 7, 2015

@cathalconnolly

This comment has been minimized.

Show comment
Hide comment
@cathalconnolly

cathalconnolly Jan 7, 2015

thanks -we're in code-freeze for 7.4.0, so this will be processed for the 7.4.1 release

cathalconnolly commented Jan 7, 2015

thanks -we're in code-freeze for 7.4.0, so this will be processed for the 7.4.1 release

@jbrinkman jbrinkman added this to the 7.4.1 milestone Jan 7, 2015

@jbrinkman jbrinkman added the nop label Jan 11, 2015

@jbrinkman jbrinkman added Community and removed nop labels Mar 3, 2015

cathalconnolly pushed a commit that referenced this pull request Mar 14, 2015

Cathal Connolly Cathal Connolly
Merge pull request #250 from skydnn/bug/dnn-6265
DNN-6265 Update OAuthClientBase to support optional parameters

@cathalconnolly cathalconnolly merged commit 12f63bc into dnnsoftware:development Mar 14, 2015

@tatigo

This comment has been minimized.

Show comment
Hide comment
@tatigo

tatigo Aug 27, 2015

I'm having issues integrating UseOpenIdConnectAuthentication to Azure (from Owin startup class).
I'm on DNN 7.04. Do I need to pull the most current Dnn version?

tatigo commented Aug 27, 2015

I'm having issues integrating UseOpenIdConnectAuthentication to Azure (from Owin startup class).
I'm on DNN 7.04. Do I need to pull the most current Dnn version?

@bdukes

This comment has been minimized.

Show comment
Hide comment
@bdukes

bdukes Aug 27, 2015

Contributor

@tatigo it looks like this change was included in 7.4.1, so if you're planning to use DNN's OAuthClientBase to create your authentication provider, than you will need to get that version of DNN.

Contributor

bdukes commented Aug 27, 2015

@tatigo it looks like this change was included in 7.4.1, so if you're planning to use DNN's OAuthClientBase to create your authentication provider, than you will need to get that version of DNN.

@jbrinkman jbrinkman added nop and removed nop labels Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment