DNN-6323 Clean list name before using as resource file name #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging into 7.4.1 |
cathalconnolly
pushed a commit
that referenced
this pull request
Feb 4, 2015
DNN-6323 Clean list name before using as resource file name
|
Hi Brian, I am QA and testing for DNN-6323. If possible, could you please provide me a sample module in JIRA, by which I can repro this problem and validate the fixes. Thanks in advance. |
jbrinkman
added
Community
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Oct 2, 2019
Fixes to Roles module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#128 and #148 added localization to list values, by looking up a resource file with the same name as the list (plus a prefix). However, if the list name contains characters that are invalid for a file, an exception is thrown (see the stack trace on EngageSoftware/Engage-Employment#6).
See DNN-6323