Update Selectize library #2907
Merged
Update Selectize library #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
Jul 24, 2019
mitchelsellers
approved these changes
Jul 27, 2019
sleupold
added a commit
to sleupold/Dnn.Platform
that referenced
this pull request
Sep 1, 2019
…form into development * 'development' of https://github.com/dnnsoftware/Dnn.Platform: (59 commits) Updating development with recent changes on release/9.4.x (dnnsoftware#2964) Removal of Obsolete Code (dnnsoftware#2869) Update development with fixes from v9.4.0-rc (dnnsoftware#2941) Enables and documents local builds (dnnsoftware#2932) Standardization of Messaging DNN-31339 DNN Platform: GetURL API in a file manager impacting CKEditor performance (dnnsoftware#2918) Ensure proper regex matching (dnnsoftware#2915) Bug template (dnnsoftware#2909) Removes duplication of license files for javascript libraries (dnnsoftware#2914) Bumps Excillion theme version (dnnsoftware#2913) Update Selectize library to 0.12.6 (dnnsoftware#2907) Added branching explanation to PR documentation DNN-30859 - Add unit test for Mail::AddAlternativeView DNN-30859 - Set AlternativeView.Encoding with bodyEncoding - This is to ensure AlternativeView encoding is always consistent with bodyEncoding and not relying on the body text - Extract the code to AddAlternateView method to allow UTs DNN-30859 - Add MailTests.cs to the project Update GlobalResources.resx (dnnsoftware#2891) Fixes an issue with the boolean values in the Google Analytics Connector (dnnsoftware#2877) Adjusted copyright Check file names for illegal characters DNN-29969 View.html file is not rendered via "Module Creator" update (dnnsoftware#2854) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this fixes #2906, where a JS file wasn't updating during an upgrade. I believe that the issue it wasn't updated is because it was packaged as part of a JavaScript Library package, and that package's version didn't change.
Since that package does have a new version, I went ahead and updated it. I expect that this will fix the issue with the outdated code.
That said, it's probably incorrect to package
dnn.combobox.jsinside of the Selectize library, and it should be moved somewhere alongside the rest of DNN's JS files.