Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error running unit tests #2940

Merged
merged 1 commit into from Aug 14, 2019
Merged

Fix error running unit tests #2940

merged 1 commit into from Aug 14, 2019

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Aug 13, 2019

When running tests, the following error occurs:

VSTest: Could not locate executable.

cake-build/cake#1522 (comment) indicates that there's an issue using VS 2019, and presents a workaround to find the correct path

When running tests, the following error occurs:
	VSTest: Could not locate executable.

cake-build/cake#1522 (comment)
indicates that there's an issue using VS 2019, and presents a workaround
to find the correct path
@bdukes bdukes requested a review from valadas August 13, 2019 20:42
@bdukes bdukes changed the base branch from development to release/9.4.x August 13, 2019 20:54
@valadas
Copy link
Contributor

valadas commented Aug 13, 2019

Thanks a lot I did not know what was happening with this.

@bdukes
Copy link
Contributor Author

bdukes commented Aug 13, 2019

Tests dashboard

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mitchelsellers mitchelsellers merged commit 22e55ea into release/9.4.x Aug 14, 2019
mitchelsellers pushed a commit that referenced this pull request Aug 15, 2019
* Fix error running unit tests (#2940)

When running tests, the following error occurs:
	VSTest: Could not locate executable.

cake-build/cake#1522 (comment)
indicates that there's an issue using VS 2019, and presents a workaround
to find the correct path

* DNN-31366 - Deleted page can still be selected as parent page (#2925)

* DNN-31366 - TabController HasChildren returns false if all children are deleted

* Simplify HasChildren condition
valadas added a commit that referenced this pull request Sep 1, 2019
* Fix error running unit tests (#2940)

When running tests, the following error occurs:
	VSTest: Could not locate executable.

cake-build/cake#1522 (comment)
indicates that there's an issue using VS 2019, and presents a workaround
to find the correct path

* DNN-31366 - Deleted page can still be selected as parent page (#2925)

* DNN-31366 - TabController HasChildren returns false if all children are deleted

* Simplify HasChildren condition

* deleting_themes_from_Extensions_doesnt_remove_it_from_themes (#2950)

* Returns the working types if some fail (#2953)
@daguiler daguiler deleted the fix-unit-tests branch October 10, 2019 13:23
DnnSoftwarePersian pushed a commit to DnnSoftwarePersian/Dnn.Platform that referenced this pull request May 17, 2020
…e#2964)

* Fix error running unit tests (dnnsoftware#2940)

When running tests, the following error occurs:
	VSTest: Could not locate executable.

cake-build/cake#1522 (comment)
indicates that there's an issue using VS 2019, and presents a workaround
to find the correct path

* DNN-31366 - Deleted page can still be selected as parent page (dnnsoftware#2925)

* DNN-31366 - TabController HasChildren returns false if all children are deleted

* Simplify HasChildren condition

* deleting_themes_from_Extensions_doesnt_remove_it_from_themes (dnnsoftware#2950)

* Returns the working types if some fail (dnnsoftware#2953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants