deleting_themes_from_Extensions_doesnt_remove_it_from_themes #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bdukes
approved these changes
Aug 15, 2019
|
I can confirm the original issue and validate that this PR fixes it, but targeting development means this will only get merged for Dnn 10, would you be able to resubmit this fix targetting 9.4.x branch since it is a non breaking change to fix a bug? |
Hi, done : #2950 |
|
Closing this and merging the other one, thanks for the help @SergeyDryomin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2943
Summary
Fixed issue with incorrect slash and trimmed whitespaces for validation File.Exists for all cases it checkes file names. UT's are added.
Also fixed to remove Theme from Extentions without removing it from Theme additionally
fix for DNN-17149 , DNN-32014