Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop occurs in vocabularies #2956

Closed

Conversation

berkarslan-xo
Copy link
Contributor

@berkarslan-xo berkarslan-xo commented Aug 19, 2019

Fixes #2955

Summary

If "System.Net.WebUtility.HtmlDecode" returns the same value as the input, it will cause an infinite loop because of the while loop. There are no needs for a while loop here since it's enough for "System.Net.WebUtility.HtmlDecode" to work only once.

Demo: https://drive.google.com/open?id=1nG5P1_drh8Ncx-AvwNcSDI1MANxAz9Ve

Note: The retargeted PR (for release/9.4.x) can be found in #2956

@berkarslan-xo berkarslan-xo changed the title DNN-29557 - Infinite while loop fix DNN-29557 - Infinite loop occurs in vocabularies Aug 19, 2019
@berkarslan-xo
Copy link
Contributor Author

Demo video is added.

@berkarslan-xo
Copy link
Contributor Author

Dear @dnnsoftware/approvers , could you review this PR please?

@mitchelsellers
Copy link
Contributor

@berkarslan-xo we are in the middle of a release cycle, this PR is targeting the development branch and will only be considered for inclusion with the 10.0 release. You could re-target for inclusion in 9.4.1, which will be released in the coming months, but we are not processing PR's for that release until 9.4.0 is released.

@valadas valadas added this to the 10.0.0 milestone Sep 10, 2019
@berkarslan-xo
Copy link
Contributor Author

Dear @dnnsoftware/approvers , could you review this PR please? Please let me know if I should open a new PR targeting another branch etc.

@david-poindexter
Copy link
Contributor

@berkarslan-xo please see the response from Aug 21. Right now, PRs targeting development will be considered for the 10.0 release. If you want this PR considered sooner, please target the release/9.4.x branch.

@berkarslan-xo
Copy link
Contributor Author

A retargeted PR, for release/9.4.x, is created.
#2956

@mitchelsellers
Copy link
Contributor

Closing this in favor of the one targeting 9.4.x

@mitchelsellers mitchelsellers changed the title DNN-29557 - Infinite loop occurs in vocabularies Infinite loop occurs in vocabularies Oct 7, 2019
@mitchelsellers mitchelsellers removed this from the 10.0.0 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop occurs in vocabularies
4 participants