Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate moment to dayjs for Pages.Web #4463

Merged
merged 2 commits into from Feb 8, 2021
Merged

Migrate moment to dayjs for Pages.Web #4463

merged 2 commits into from Feb 8, 2021

Conversation

david-poindexter
Copy link
Contributor

Summary

Migrate moment to dayjs for Pages.Web project. This relates to #3875.

@david-poindexter david-poindexter added this to the 9.9.0 milestone Feb 7, 2021
@david-poindexter david-poindexter self-assigned this Feb 7, 2021
@david-poindexter david-poindexter mentioned this pull request Feb 7, 2021
Closed
18 tasks
valadas
valadas requested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit for clarity :)

Dnn.AdminExperience/ClientSide/Pages.Web/src/utils.js Outdated Show resolved Hide resolved
@david-poindexter
Move dayjs extension near imports
0941693 
Move const for dayjs extension to just after imports section.
valadas
valadas approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mitchelsellers mitchelsellers merged commit eca8bc2 into dnnsoftware:develop Feb 8, 2021
@david-poindexter david-poindexter deleted the issue-3875-pages branch May 31, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Type: Enhancement
Projects
None yet
Milestone
9.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@david-poindexter @mitchelsellers @valadas