Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new Google Analytics 4 Connector #5666

Merged
merged 1 commit into from Jun 12, 2023

Conversation

david-poindexter
Copy link
Contributor

@david-poindexter david-poindexter commented Jun 11, 2023

Summary

Resolves #5665

image

image

image

image

image

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@david-poindexter david-poindexter changed the title Add Google Analytics 4 connector Add Google Analytics 4 Connector Jun 11, 2023
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@valadas valadas merged commit a3a2496 into dnnsoftware:develop Jun 12, 2023
4 checks passed
@valadas valadas changed the title Add Google Analytics 4 Connector Added a new Google Analytics 4 Connector Jun 14, 2023
@bdukes
Copy link
Contributor

bdukes commented Jun 15, 2023

@dnnsoftware/approvers should we remove the old GA connector? There's no reason to include it in new installs anymore, right?

@mitchelsellers
Copy link
Contributor

@bdukes for a clean installation, you are most likely correct

@valadas
Copy link
Contributor

valadas commented Jun 15, 2023

Makes sense to me, upgrades would keep and people can uninstall it when not needed anymore. But... The module (UI) is only part of it, the actual engine is solely driven by the config file. Sooo, people would have to disconnect, then uninstall. One of the things I wanted to do (when I have some time) is to be able to call something like IUpgradeable but for uninstallation of a module. Basically define a method that gets called before the rest of the normal uninstall happens. That could be a nice solution for this but I won't have enough time to do it in v9... Maybe v10...

@david-poindexter david-poindexter deleted the ga4-connector branch June 15, 2023 23:20
@david-poindexter
Copy link
Contributor Author

david-poindexter commented Jun 15, 2023

@dnnsoftware/approvers should we remove the old GA connector? There's no reason to include it in new installs anymore, right?

In principle, I agree. In practice, there are some details about the base engine implementation that will require some thought as to how to unravel it all. For instance, it depends on the default SiteAnalytics.config file (which contains the old GA script).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Analytics 4 (GA4) Connector
4 participants