-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve train_test_split #12
Comments
I am currently using this: class NeuralNetFix(NeuralNet):
def train_test_split(self, X, y, eval_size):
assert eval_size is None
X_train = X
y_train = y
X_valid = self.X_valid
y_valid = self.y_valid
if not self.regression and self.use_label_encoder:
y_valid = self.enc_.transform(y_valid).astype(np.int32)
return X_train, X_valid, y_train, y_valid I then handle the UPDATE: I no longer read |
@cancan101 To answer your first question: You'll notice that But maybe the stratified split isn't all that important, and we can just use an overridable train_test_split (component) by default. |
For
NeuralNet
:train_test_split
rather than usingsklearn.cross_validation::train_test_split
?-- This would fix train_test_split does not work for Pandas Series with non Dense Index #7 because it uses
safe_indexing
.NeuralNet
which is not ideal.The text was updated successfully, but these errors were encountered: