Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train_test_split signature #42

Closed
cancan101 opened this issue Feb 10, 2015 · 2 comments
Closed

train_test_split signature #42

cancan101 opened this issue Feb 10, 2015 · 2 comments

Comments

@cancan101
Copy link
Contributor

Any reason the signature for train_test_split takes in the eval_size rather than just reason self. eval_size?

def train_test_split(self, X, y, eval_size):

@dnouri
Copy link
Owner

dnouri commented Feb 19, 2015

Not sure, to be honest. It may allow us to swap in more easily a train_test_split function passed as a parameter to NeuralNet, one that equally takes a eval_size argument. I remember we discussed being able to pass train_test_split in as a component similar to batch_iterator_train. Though it's more of a guess right now that these three arguments (X, y, eval_size) would be an appropriate interface to such a component.

This was referenced Feb 19, 2015
@dnouri
Copy link
Owner

dnouri commented Jul 22, 2015

Obsolete with #125

@dnouri dnouri closed this as completed Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants