Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Commit

Permalink
In Java, CommandHeader builder methods now all return `CommandHeade…
Browse files Browse the repository at this point in the history
…rs`.

Fix #417
  • Loading branch information
emgre committed Apr 18, 2022
1 parent e8b1de4 commit 5f41cc9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* :beetle: Fix keep-alive timer not properly calculated. See [#407](https://github.com/dnp3/opendnp3/pull/407).
* :beetle: Fix `LinkContext` and `MContext` possible lifetime issue.
See [#407](https://github.com/dnp3/opendnp3/pull/407).
* :beetle: In Java, `CommandHeader` builder methods now all return `CommandHeaders`.
See [#440](https://github.com/dnp3/opendnp3/pull/440).

### 3.1.1 ###
* :beetle: Fix static octet string serilazation bug.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ public static CommandHeaders fromAO16(Iterable<IndexedValue<AnalogOutputInt16>>
return new CommandHeader((CommandBuilder b) -> b.addAO16(commands));
}

public static CommandHeader fromAO32(Iterable<IndexedValue<AnalogOutputInt32>> commands)
public static CommandHeaders fromAO32(Iterable<IndexedValue<AnalogOutputInt32>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAO32(commands));
}

public static CommandHeader fromAOFloat32(Iterable<IndexedValue<AnalogOutputFloat32>> commands)
public static CommandHeaders fromAOFloat32(Iterable<IndexedValue<AnalogOutputFloat32>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAOFloat32(commands));
}

public static CommandHeader fromAODouble64(Iterable<IndexedValue<AnalogOutputDouble64>> commands)
public static CommandHeaders fromAODouble64(Iterable<IndexedValue<AnalogOutputDouble64>> commands)
{
return new CommandHeader((CommandBuilder b) -> b.addAODouble64(commands));
}
Expand All @@ -69,17 +69,17 @@ public static CommandHeaders fromSingleAO16(AnalogOutputInt16 command, int index
return fromAO16(wrap(command, index));
}

public static CommandHeader fromSingleAO32(AnalogOutputInt32 command, int index)
public static CommandHeaders fromSingleAO32(AnalogOutputInt32 command, int index)
{
return fromAO32(wrap(command, index));
}

public static CommandHeader fromSingleAOFloat32(AnalogOutputFloat32 command, int index)
public static CommandHeaders fromSingleAOFloat32(AnalogOutputFloat32 command, int index)
{
return fromAOFloat32(wrap(command, index));
}

public static CommandHeader fromSingleAODouble64(AnalogOutputDouble64 command, int index)
public static CommandHeaders fromSingleAODouble64(AnalogOutputDouble64 command, int index)
{
return fromAODouble64(wrap(command, index));
}
Expand Down

0 comments on commit 5f41cc9

Please sign in to comment.