Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Inconsistent return-types in CommandHeader.java #417

Closed
OOPMan opened this issue Jan 18, 2021 · 1 comment
Closed

Inconsistent return-types in CommandHeader.java #417

OOPMan opened this issue Jan 18, 2021 · 1 comment

Comments

@OOPMan
Copy link

OOPMan commented Jan 18, 2021

Hi, the return-types in java/bindings/src/main/java/com/automatak/dnp3/CommandHeader.java seem a bit inconsistent.

The following return class CommandHeader:

  • fromSingleCROB
  • fromSingleAO16
  • fromCROB
  • fromAO16

The following return interface CommandHeaders:

  • fromSingleAO32
  • fromSingleAOFloat32
  • fromSingleAODouble64
  • fromAO32
  • fromAOFloat32
  • fromAODouble64

This issue also applies to the

@jadamcrain
Copy link
Member

jadamcrain commented Jan 20, 2021

It should just return the interface type CommandHeaders, not the impl type CommandHeader.

I think we can safely fix this in the next patch release as the impl type doesn't expose any additional methods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants