This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Add support for configurable unsolicited response retries #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing some test cases and bindings. Also need to check broadcast behaviour.
…sol-num-retries # Conflicts: # cpp/lib/src/outstation/OutstationContext.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322 and #321.
NumRetrieshas two static member functions to create a fixed number of maximum retries or an infinite number of retries.unsolRetryTimeoutwas removed.allowUnsolicitedis nowtrue, to better reflect the C++ API.unsolicitedConfirmTimeoutforunsolConfirmTimeoutto better reflect the C++ APIsolConfirmTimeoutwas never used. TheunsolConfirmTimeoutwas used for both solicited and unsolicited responses. Now, the appropriate values are used. A test case was also added for this bug.