Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Fix remaining items for 3.0 release #367

Merged
merged 12 commits into from Apr 27, 2020
Merged

Fix remaining items for 3.0 release #367

merged 12 commits into from Apr 27, 2020

Conversation

emgre
Copy link
Member

@emgre emgre commented Apr 22, 2020

  • Fix migrate library to use header-only Automatak libs #290: the only lib that was still exposed publicly was log4cpp. Since it's small and not really used elsewhere, it was copied right into opendnp3 and all references to it was removed. The library doesn't have any public dependency 🎉 (except for OpenSSL when compiling with TLS support).
  • Fix TaskConfig::With taking a reference with an undetermined lifetime #238: TaskConfig now takes a std::shared_ptr instead of a reference.
  • Fix Use exceptions instead of error_code #293: Instead of having an out-parameter for the result of DNP3Manager calls, it now throws a DNP3Error.
    • All methods of DNP3Manager can throw an exception, notably because the manager was shutdown.
    • When creating a server, we check if we can bind to the network adapter and throw an exception if we cannot. This makes the library fail early in case of misconfiguration.
    • Exceptions can only be thrown in DNP3Manager. No need to try ... catch the world.
    • Instead of swallowing errors and returning nullptr in the Java bindings, an actual exception is thrown when something goes wrong.
  • Fix remove support for transmitting link-layer confirmed user data in 3.0 #364: data-link confirmation is a broken feature in the spec and it therefore not supported anymore. It still supports receiving confirmed user data and acknowledging them for interoperability.
  • Fix LinkLayer Race Condition #138: removing data-link confirmation greatly simplified the link-layer state machine. The transient TransmitWait state was removed so this old bug should finally be fixed.
  • Fix Please support exporting cmake files #347: CMake export was added to the installed files.

@emgre emgre changed the title Feature/remove log4cpp Fix remaining items for 3.0 release Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #367 into develop will decrease coverage by 0.27%.
The diff coverage is 59.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #367      +/-   ##
===========================================
- Coverage    46.97%   46.70%   -0.28%     
===========================================
  Files          502      504       +2     
  Lines        15590    15584       -6     
===========================================
- Hits          7323     7278      -45     
- Misses        8267     8306      +39     
Impacted Files Coverage Δ
cpp/lib/include/opendnp3/ConsoleLogger.h 0.00% <0.00%> (ø)
cpp/lib/include/opendnp3/DNP3Manager.h 100.00% <ø> (ø)
cpp/lib/include/opendnp3/ErrorCodes.h 0.00% <0.00%> (-25.00%) ⬇️
...lib/include/opendnp3/app/ControlRelayOutputBlock.h 0.00% <0.00%> (ø)
cpp/lib/include/opendnp3/app/OctetString.h 50.00% <ø> (-16.67%) ⬇️
cpp/lib/include/opendnp3/channel/ChannelRetry.h 100.00% <ø> (ø)
cpp/lib/include/opendnp3/channel/IChannel.h 100.00% <ø> (ø)
cpp/lib/include/opendnp3/channel/SerialSettings.h 0.00% <ø> (ø)
cpp/lib/include/opendnp3/link/LinkConfig.h 0.00% <ø> (ø)
cpp/lib/include/opendnp3/logging/ILogHandler.h 0.00% <0.00%> (ø)
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf34bd7...8bfb68c. Read the comment docs.

@emgre emgre force-pushed the feature/remove-log4cpp branch 2 times, most recently from c4f9e6d to e016193 Compare April 24, 2020 20:15
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2020

This pull request fixes 2 alerts when merging 8bfb68c into bf34bd7 - view on LGTM.com

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Sign check of bitwise operation

@emgre emgre merged commit a5fb103 into develop Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant