This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emgre
force-pushed
the
feature/remove-log4cpp
branch
from
April 23, 2020 12:47
fbf21e2
to
aa65f08
Compare
Codecov Report
@@ Coverage Diff @@
## develop #367 +/- ##
===========================================
- Coverage 46.97% 46.70% -0.28%
===========================================
Files 502 504 +2
Lines 15590 15584 -6
===========================================
- Hits 7323 7278 -45
- Misses 8267 8306 +39
Continue to review full report at Codecov.
|
emgre
force-pushed
the
feature/remove-log4cpp
branch
2 times, most recently
from
April 24, 2020 20:15
c4f9e6d
to
e016193
Compare
emgre
force-pushed
the
feature/remove-log4cpp
branch
from
April 27, 2020 14:06
e016193
to
8bfb68c
Compare
This pull request fixes 2 alerts when merging 8bfb68c into bf34bd7 - view on LGTM.com fixed alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log4cpp
. Since it's small and not really used elsewhere, it was copied right into opendnp3 and all references to it was removed. The library doesn't have any public dependency 🎉 (except for OpenSSL when compiling with TLS support).TaskConfig
now takes astd::shared_ptr
instead of a reference.DNP3Manager
calls, it now throws aDNP3Error
.DNP3Manager
can throw an exception, notably because the manager was shutdown.DNP3Manager
. No need totry ... catch
the world.nullptr
in the Java bindings, an actual exception is thrown when something goes wrong.TransmitWait
state was removed so this old bug should finally be fixed.