This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Fix EventOnly behaviour #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #385 +/- ##
===========================================
- Coverage 51.75% 51.72% -0.03%
===========================================
Files 456 456
Lines 13602 13602
===========================================
- Hits 7040 7036 -4
- Misses 6562 6566 +4
Continue to review full report at Codecov.
|
jadamcrain
reviewed
Jun 4, 2020
| @@ -48,7 +48,8 @@ enum class EventMode : uint8_t | |||
| Force = 0x1, | |||
| /// Never produce an event regardless of changes | |||
| Suppress = 0x2, | |||
| /// Send an event directly to the event buffer, bypassing the static value completely | |||
| /// Force the creation of an event bypassing detection mechanism, but does not | |||
There was a problem hiding this comment.
We need to update this comment via the code generator. It will also update java/.net
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #384.
EventOnlybehaviour to match the 2.x.0.0.0.0is more common default thanasdf.