Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Fix EventOnly behaviour (Reprise) #386

Merged
merged 1 commit into from Jun 9, 2020
Merged

Fix EventOnly behaviour (Reprise) #386

merged 1 commit into from Jun 9, 2020

Conversation

emgre
Copy link
Member

@emgre emgre commented Jun 8, 2020

Fix #384 (Reprise).

The fix in #385 was not enough, since it kept reporting the old static value. I added unit tests that verify both the static and the event value to make sure this fix works.

@emgre emgre requested a review from jadamcrain June 8, 2020 19:07
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #386 into develop will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
- Coverage    51.72%   51.69%   -0.03%     
===========================================
  Files          456      456              
  Lines        13602    13602              
===========================================
- Hits          7036     7032       -4     
- Misses        6566     6570       +4     
Impacted Files Coverage Δ
cpp/lib/src/outstation/StaticDataMap.h 90.65% <100.00%> (-3.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcc7ac...7ba370a. Read the comment docs.

@emgre emgre merged commit d63404f into develop Jun 9, 2020
@emgre emgre deleted the bugfix/event-only branch June 9, 2020 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant