Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector template output: query_response_flags response has no question bit inverted #50

Open
banburybill opened this issue Jun 18, 2019 · 0 comments
Open

inspector template output: query_response_flags response has no question bit inverted #50

banburybill opened this issue Jun 18, 2019 · 0 comments

Comments

@banburybill
Copy link
Contributor

The value substituted for template identifier 'query_response_flags' has the topmost bit, 'Response has no question' inverted. The bit is set if the response has a question. The value therefore does not match the C-DNS spec value.

The individual item 'query_response_response_has_question' is correct.
banburybill pushed a commit that referenced this issue Sep 20, 2019
Update template results gold files.
c5604af 
There are two problems with the existing ones.

1. The top bit of the query-response flags is inverted. #50
2. Bit values in transport flags have changed since format 0.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@banburybill