Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAS compile failure #2583

Closed
jasoncook opened this issue May 13, 2016 · 8 comments
Closed

CRAS compile failure #2583

jasoncook opened this issue May 13, 2016 · 8 comments

Comments

@jasoncook
Copy link

name: kali-rolling
encrypted: no
Entering /var/crouton/chroots/kali-rolling...
crouton: version git
release: kali-rolling
architecture: amd64
xmethod: xiwi
targets: xiwi,xfce
host: version 8302.0.0 (Official Build) dev-channel leon 
kernel: Linux localhost 3.8.11 #1 SMP Mon May 9 22:09:11 PDT 2016 x86_64 GNU/Linux
freon: yes
Unmounting /var/crouton/chroots/kali-rolling...

Please describe your issue:

I just upgraded to Version 52.0.2727.0 dev (64-bit) and I'm receiving the same error as listed in #2572

Compiling CRAS (i386)...
common/cras_config.c: In function 'cras_config_get_system_socket_file_dir':
common/cras_config.c:16:9: error: 'CRAS_SOCKET_FILE_DIR' undeclared (first use in this function)
  return CRAS_SOCKET_FILE_DIR;
         ^
common/cras_config.c:16:9: note: each undeclared identifier is reported only once for each function it appears in
common/cras_config.c:17:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
Failed to complete chroot setup.

If known, describe the steps to reproduce the issue:

Previous version of ChromeOS did not produce this error.

@randfur
Copy link

randfur commented May 14, 2016

Seeing this as well when running crouton -t xfce.
Using Chrome 52.0.2727.0 (Official Build) dev (64-bit).

Compiling CRAS (i386)...
common/cras_config.c: In function 'cras_config_get_system_socket_file_dir':
common/cras_config.c:16:9: error: 'CRAS_SOCKET_FILE_DIR' undeclared (first use in this function)
common/cras_config.c:16:9: note: each undeclared identifier is reported only once for each function it appears in
common/cras_config.c:17:1: error: control reaches end of non-void function [-Werror=return-type]
cc1: all warnings being treated as errors
Failed to complete chroot setup.
Unmounting /mnt/stateful_partition/crouton/chroots/precise...

@sgosnell
Copy link

sgosnell commented May 15, 2016

Same thing for me, running Jessie. It started today after updating to the newest Dev Channel version. It won't run as is, and won't update.

Edit: tried to run the chroot again, and it asked if I wanted to finish the chroot installation. I said yes, and it ran the chroot. It won't update, but it does run, eventually.

@gs0622
Copy link

gs0622 commented May 16, 2016

I am guessing it might be due to this commit:
https://chromium.googlesource.com/chromiumos/third_party/adhd/+/8d225aa3ef953f235d788509a0ba23b1f6504a5d%5E%21/

It looks to me expecting to use configure script to define CRAS_SOCKET_FILE_DIR however crouton installation script uses Makefile.am directly.

drinkcat added a commit to drinkcat/chroagh that referenced this issue May 16, 2016
Since upstream commit 8d225aa3ef953f235d788509a0ba23b1f6504a5d
"CRAS: Make socket directory configurable.", we need to define
CRAS_SOCKET_FILE_DIR="/var/run/cras" manually.

Fixes dnschneid#2583.
@drinkcat
Copy link
Collaborator

Can someone test #2589 ? I only compile tested it. Thanks!

@sgosnell
Copy link

sgosnell commented May 17, 2016

I get this:
Compiling CRAS (i386)... common/cras_config.c: In function 'cras_config_get_system_socket_file_dir': common/cras_config.c:16:9: error: 'CRAS_SOCKET_FILE_DIR' undeclared (first use in this function) return CRAS_SOCKET_FILE_DIR; ^ common/cras_config.c:16:9: note: each undeclared identifier is reported only once for each function it appears in common/cras_config.c:17:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors Failed to complete chroot setup.

But as before, I then start the chroot, get asked if I want to finish the setup, answer yes, and it compiles CRAS and runs. I'm not sure if the update completes fully, but the chroot does run. I'm running Jessie, so the changes to the update should be minimal, if any.

@gs0622
Copy link

gs0622 commented May 17, 2016

Tested #2589 twice, works for me.

@jasoncook
Copy link
Author

#2589 worked for me too. Excellent work.

@chrisj42
Copy link

I have been having this problem for the last couple months as well. I was getting desperate just when I saw #2589 had been merged. Resolved problem! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants