Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook removes undesired records #9

Closed
josacar opened this issue Dec 16, 2013 · 5 comments · Fixed by #12
Closed

Cookbook removes undesired records #9

josacar opened this issue Dec 16, 2013 · 5 comments · Fixed by #12

Comments

@josacar
Copy link
Contributor

josacar commented Dec 16, 2013

When having for example these records on a zone:

    A 1.1.1.1
    MX wadus
    NS 1.1.1.1
    CNAME wadus

When running the LWRP with any of these records, the first record will be destroyed no matter which type is.

@ghost ghost assigned dje Jan 11, 2014
@josacar
Copy link
Contributor Author

josacar commented Jan 11, 2014

@dje I've forked it and done a fix here

@dje
Copy link
Contributor

dje commented Jan 11, 2014

Thanks @josacar. Would you mind putting a pull request together?

@josacar
Copy link
Contributor Author

josacar commented Jan 11, 2014

I'm just writing some chefspec unit and integration tests to ensure all is working as expected.

@dje
Copy link
Contributor

dje commented Jan 11, 2014

Awesome. FWIW I'm planning on adding Test Kitchen to this cookbook early next week unless someone beats me to it.

@josacar
Copy link
Contributor Author

josacar commented Jan 11, 2014

I've pushed them on my repo, but fog/dnsimple has a different behaviour on get_domain mock, trying to get it merged in upstream before making the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants