Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license and github link to hex info of .app.src #32

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

tsloughter
Copy link
Contributor

No description provided.

@tsloughter
Copy link
Contributor Author

Could you also make a new release?

@tsloughter
Copy link
Contributor Author

I wonder if its not using the 'version-type: strict' since this is a forked PR.

@DXTimer
Copy link

DXTimer commented Sep 25, 2023

I checked the docs for the erlef/setup-beam GH Action and their support matrix shows that ubuntu-latest (ubuntu-22.04) supports 24.2+. Would you mind making the changes in the workflow to change the target to ubuntu-20.04?

@tsloughter
Copy link
Contributor Author

Ah. And you want that instead of bumping to 24.2+? Or even testing on 26 instead of an older version?

@tsloughter
Copy link
Contributor Author

Well, not just 26, but 24.2, 25, 26.

@DXTimer
Copy link

DXTimer commented Sep 26, 2023

I agree with you on covering more versions including 26.

@tsloughter
Copy link
Contributor Author

The slack hook fails.

Copy link

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, it looks great. I'll look into disabling the Slack job for forked PRs.

@DXTimer DXTimer merged commit ac08978 into dnsimple:main Oct 2, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants