-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint-config-standard from 13.0.1 to 16.0.1 #66
Bump eslint-config-standard from 13.0.1 to 16.0.1 #66
Conversation
@dependabot rebase |
Bumps [eslint-config-standard](https://github.com/standard/eslint-config-standard) from 13.0.1 to 16.0.1. - [Release notes](https://github.com/standard/eslint-config-standard/releases) - [Changelog](https://github.com/standard/eslint-config-standard/blob/master/CHANGELOG.md) - [Commits](standard/eslint-config-standard@v13.0.1...v16.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
067cd8f
to
ef7b966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Great work.
I made a comment about a const
that may break.
At some point, we should do a find-and-replace of function () {
to () => {
so we can get rid of the const self = this
, but that's a problem for another time.
A newer version of eslint-config-standard exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@@ -9,6 +9,7 @@ | |||
- CHANGED: Bump nock from 13.0.0 to 13.0.4 | |||
- CHANGED: Bump mocha from 8.0.1 to 8.2.1 | |||
- CHANGED: Bump snazzy from 8.0.0 to 9.0.0 | |||
- CHANGED: Bump eslint-config-standard from 13.0.1 to 16.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@san983 FYI no need to track every single dependency update in the CHANGELOG, unless it has significant impact on the final user.
Bumps eslint-config-standard from 13.0.1 to 16.0.1.
Commits
90742cb
16.0.168780a7
change "no-var" to a warning033b3df
style2c97f4b
16.0.0204dee1
fix tests5c664f2
standard5db3b49
Require let or const instead of var (no-var)2e39843
Relax rule: Do not enforce camelcase style for global variables (camelcase)fbc0891
sort0f4d3f2
remove eslint-plugin-standardDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: