Skip to content

Commit

Permalink
[RSpec/RepeatedDescription] Don't repeat descriptions within an examp…
Browse files Browse the repository at this point in the history
…le group

As there was a typo in a spec title
  • Loading branch information
san983 committed Mar 29, 2021
1 parent ddbcf41 commit c9d24fe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-03-29 11:45:17 UTC using RuboCop version 1.12.0.
# on 2021-03-29 11:48:18 UTC using RuboCop version 1.12.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -39,11 +39,6 @@ RSpec/MultipleExpectations:
RSpec/NamedSubject:
Enabled: false

# Offense count: 2
RSpec/RepeatedDescription:
Exclude:
- 'spec/dnsimple/client/zones_spec.rb'

# Offense count: 10
RSpec/StubbedMock:
Exclude:
Expand Down
2 changes: 1 addition & 1 deletion spec/dnsimple/client/zones_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&sort=name:desc")
end

it "supports sorting" do
it "supports filtering" do
subject.all_zones(account_id, filter: { name_like: "zone.test" })

expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&name_like=zone.test")
Expand Down

0 comments on commit c9d24fe

Please sign in to comment.