Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record type should be :type not :record_type #75

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

jacegu
Copy link
Contributor

@jacegu jacegu commented Feb 26, 2016

We are validating presence of record_type when creating a record yet the API expects type to be sent.

@jacegu jacegu added bug ready-for-review Pull requests that are ready to be reviewed by other team members. labels Feb 26, 2016
@jacegu jacegu self-assigned this Feb 26, 2016
@weppos
Copy link
Member

weppos commented Feb 26, 2016

👍

weppos added a commit that referenced this pull request Feb 26, 2016
Record type should be :type not :record_type
@weppos weppos merged commit c9b231b into master Feb 26, 2016
@weppos weppos deleted the bugfix/type-vs-record-type branch February 26, 2016 11:13
@weppos
Copy link
Member

weppos commented Feb 26, 2016

Merged, thanks @jacegu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants