Fix stuff Sonar considers as a bug

dnsjava · Nov 5, 2023 · c2b28b8 · c2b28b8
1 parent cd23ca6
commit c2b28b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/main/java/org/xbill/DNS/dnssec/ByteArrayComparator.java b/src/main/java/org/xbill/DNS/dnssec/ByteArrayComparator.java
@@ -16,10 +16,7 @@ final class ByteArrayComparator {
   private static final int MAX_BYTE = 0xFF;
 
   /** {@inheritDoc} */
-  public int compare(Object o1, Object o2) {
-    byte[] b1 = (byte[]) o1;
-    byte[] b2 = (byte[]) o2;
-
+  public int compare(byte[] b1, byte[] b2) {
     if (b1.length != b2.length) {
       return b1.length - b2.length;
     }

diff --git a/src/test/java/org/xbill/DNS/NameTest.java b/src/test/java/org/xbill/DNS/NameTest.java
@@ -378,14 +378,14 @@ void ctor_max_length_rel_with_abs_origin() throws TextParseException {
     }
 
     @Test
-    void ctor_too_long_rel_with_rel_origin() throws TextParseException {
+    void ctor_too_long_rel_with_rel_origin() {
       // relative name with three 63-char labels and a 53-char label with an 8-char relative origin
       assertThrows(
           TextParseException.class,
           () ->
               new Name(
                   "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc.ddddddddddddddddddddddddddddddddddddddddddddddddddddd",
-                  new Name("relative")));
+                  Name.fromConstantString("relative")));
     }
 
     @Test
@@ -396,7 +396,7 @@ void ctor_too_long_rel_with_abs_origin() {
           () ->
               new Name(
                   "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc.ddddddddddddddddddddddddddddddddddddddddddddddddddddd",
-                  new Name("absolute.")));
+                  Name.fromConstantString("absolute.")));
     }
 
     @Test